- 05 Apr, 2018 5 commits
-
-
Jan Mayer authored
Signed-off-by:
Jan Mayer <jan.mayer@ikp.uni-koeln.de>
-
Jan Mayer authored
Signed-off-by:
Jan Mayer <jan.mayer@ikp.uni-koeln.de>
-
Jan Mayer authored
Signed-off-by:
Jan Mayer <jan.mayer@ikp.uni-koeln.de>
-
Jan Mayer authored
Always rebuild libraries via dlmgr in tmp dir when running test. Signed-off-by:
Jan Mayer <jan.mayer@ikp.uni-koeln.de>
-
Jan Mayer authored
Signed-off-by:
Jan Mayer <jan.mayer@ikp.uni-koeln.de>
-
- 04 Apr, 2018 5 commits
-
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
The only C++14 dependency was std::make_unique. This adds a compatibility layer to provide a make_unique implementation when compiling against C++11.
-
Nima Saed-Samii authored
- 03 Apr, 2018 4 commits
-
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
- 02 Apr, 2018 1 commit
-
-
Nima Saed-Samii authored
-
- 01 Apr, 2018 16 commits
-
-
Nima Saed-Samii authored
The macro ClassDefOverride uses the C++11 override keyword instead of virtual. This eliminates some compiler warnings about mixed usage of virtual and override.
-
Nima Saed-Samii authored
This also converts some loops to range-based loops.
-
Nima Saed-Samii authored
Evaluating a fitter does not change its internal state.
-
Nima Saed-Samii authored
Explicit new/deletes are ugly. As a further benefit, using make_unique makes the allocation exception-safe.
-
Nima Saed-Samii authored
This makes sure, all class constructors initialize every member variable. Overriding implementations of member functions in derived classes are marked override instead of virtual.
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
Marking single argument constructors explicit avoids unintentional object creation through implicit conversion.
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
STL algorithms usually perform better than handwritten code and make the code more readable.
-
Nima Saed-Samii authored
fLevel is unsigned and cannot be smaller than zero.
-
Nima Saed-Samii authored
Calling virtual functions in con-/destructors is dangerous. This replaces virtual calls with non-virtual calls where necessary.
-
Nima Saed-Samii authored
-
- 30 Mar, 2018 8 commits
-
-
Nima Saed-Samii authored
C-style casts are error prone and hard to find. This removes all unnecessary casts and replaces the remaining C-style casts with C++-style casts.
-
Nima Saed-Samii authored
-
Nima Saed-Samii authored
The code has become quite unreadable over time. This fixes all code to be in the same indentation format and also wraps long lines to fit within 80 characters.
-
Nima Saed-Samii authored
The code has become quite unreadable over time. This fixes all code to be in the same indentation format and also wraps long lines to fit within 80 characters.
-
Nima Saed-Samii authored
The code has become quite unreadable over time. This fixes all code to be in the same indentation format and also wraps long lines to fit within 80 characters.
-
Nima Saed-Samii authored
Member functions with definitions in the class body are implicitly marked inline.
-
Nima Saed-Samii authored
Member functions with definitions in the class body are implicitly marked inline.
-
Nima Saed-Samii authored
Member functions with definitions in the class body are implicitly marked inline.
-
- 29 Mar, 2018 1 commit
-
-
Nima Saed-Samii authored
The current Makefiles (1) do not follow the naming convention used by implicit GNU make rules, e.g. the CPP variable name is supposed to be the C pre-processor not the C++ compiler and (2) most of the content is repeated boilerplate to compile a shared library that integrates well with CERN ROOT. This commit implicit GNU make rules where possible and also changes dependency generation to be actually useful. Additionally all whitespace errors detected by git (spaces before tabs and trailing whitespaces) are fixed.
-